android / android-studio-poet

Large Android projects generator
Apache License 2.0
702 stars 85 forks source link

Remove kotlin-android-extensions. #141

Closed runningcode closed 3 years ago

runningcode commented 3 years ago

They are deprecated and generate deprecation warnings.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

borisf commented 3 years ago

Nelson, please accept the CLA. In addition, please take a look at the travis build fail

runningcode commented 3 years ago

@borisf thanks for the reminder. I'm working on it! Cheers.

runningcode commented 3 years ago

@googlebot I signed it!

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

runningcode commented 3 years ago

@borisf The CI failure looks like an issue where the build is using a version of Gradle that does not support java 11 but Travis is creating the build with Java 11.

There are two options:

Let me know how to proceed. I will make a separate PR with the changes.

It should be noted that the travis CI job has a shutdown warning at the top of the page which reads:

Please be aware travis-ci.org will be shutting down in several weeks, with all accounts migrating to travis-ci.com. Please stay tuned here for more information.

runningcode commented 3 years ago

@borisf we signed the corporate CLA, but the link to verify is http://linkremoved over here: https://opensource.google/docs/cla/#cla-accepted

Is there another way to check if it has been signed?

borisf commented 3 years ago

Thanks Nelson, let me follow up with the CLA first

runningcode commented 3 years ago

@googlebot I signed it!

borisf commented 3 years ago

Hi Nelson, please fix the Travis-CI, and I will merge the PR

runningcode commented 3 years ago

@borisf travis is fixed!