Add compose support - Githubissues

android / android-studio-poet

Large Android projects generator

Apache License 2.0

702 stars 85 forks source link

Add compose support #153

Closed chao2zhang closed 2 years ago

chao2zhang commented 2 years ago

Summary

The compose variant will be equivalent to data binding. Modifier.onClick will be set for Text() and Image() composeables if we specify actions.

Test

I added several configs under configs/compose/ and verify that the generated project can be installed and run without modification.

borisf commented 2 years ago

Thanks @chao2zhang , I will take a deeper look tomorrow

borisf commented 2 years ago

@chao2zhang looks great, thanks. Can you kindly add an md file with developer know how (how to use/example/how to modify/add), on how to use etc' thus more developers can understand and resuse the functionality. Happy to help :)

chao2zhang commented 2 years ago

Do you mean to enrich the top-level README.md? Particularly I could add the composeConfig there.

Additionally, this PR is not the final PR for me. I am still planning to add a viewBinding option and would like to compare the build speed for plain vs dataBinding vs viewBinding vs compose.

borisf commented 2 years ago

Do you mean to enrich the top-level README.md? Particularly I could add the composeConfig there.

Boris - great, let's update the top level README.md, to make sure everyone can understand the functionality

Additionally, this PR is not the final PR for me. I am still planning to add a viewBinding option and would like to compare the build speed for plain vs dataBinding vs viewBinding vs compose.

Boris - this is great, thanks