search

android / architecture-components-samples

Samples for Android Architecture Components.
https://d.android.com/arch
Apache License 2.0
23.4k stars 8.29k forks source link

Update PagingWithNetwork build versions #1015

Closed claraf3 closed 2 years ago

claraf3 commented 3 years ago

Bump Paging version to 3.1.0-alpha04 and Room version to 2.4.0-alpha05 and added room-paging to dependency

Test: N/A

ggfan commented 3 years ago

just curious: the repo probably meant to be updated in the root versions.gradle. If it works with previous alpha version, then the formal release of that version should work, correct? The correct way probably should put the latest formal release versions into versions.gradle at root, and run update_versions.sh to update all. If this particular sample needs this latest alpha(which does not seem to be necessary as there is no source code change in this Pull Request), you could only change this and at the risk of being overwritten at any time (need some guarding then). May you double check on this? (probably do not merge it now).

dlam commented 2 years ago

Done in #1023