android / architecture-components-samples

Samples for Android Architecture Components.
https://d.android.com/arch
Apache License 2.0
23.4k stars 8.29k forks source link

GithubBrowserSample - Update loading_state visibility #938

Closed tomashavlicek closed 3 years ago

tomashavlicek commented 3 years ago

When the return type is Flow<List>, querying an empty table emits an empty list, thus may result into hiding the container view. Update the container view visibility by the resource status will enable usage of loading_state.xml even for resources with lists as the data.

google-cla[bot] commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.