search

android / architecture-components-samples

Samples for Android Architecture Components.
https://d.android.com/arch
Apache License 2.0
23.4k stars 8.29k forks source link

Why Github Sample not updated to use hilt, coroutines and flow #966

Open burhankhanzada opened 3 years ago

burhankhanzada commented 3 years ago

I want to follow best practices for modern android develop and GitHub sample is a complete solution for that but there soe much old code and like using dagger 2 why its not updating to use hilt and koltin continues and flow for background work instead of executors

sdfgsdfgd commented 3 years ago

this is so true, especially with private val viewModel: ExampleViewModel by hiltNavGraphViewModels(R.id.navgraphid) hilt nav graph parameter VM injections, I'd love to see this in sample and also an example of global actions between different nav graphs using these.

DJDrama commented 3 years ago

Well because hilt is beta ??

TheSomeshKumar commented 3 years ago

Well because hilt is beta ??

Well, It isn't anymore

DJDrama commented 3 years ago

Well because hilt is beta ??

Well, It isn't anymore

it was beta when this question was written