android / architecture-components-samples

Samples for Android Architecture Components.
https://d.android.com/arch
Apache License 2.0
23.44k stars 8.28k forks source link

Performed fragment injection in onFragmentAttached instead onFragmentCreated #973

Open nayan-dhabarde opened 3 years ago

nayan-dhabarde commented 3 years ago

Performing AndroidSupportInjection.inject method in onCreate of Fragment Life Cycle can lead to inconsistencies when the fragment is reattached which leads to the issue in which androidInjector() in the fragment returns null.

It is recommended in the Dagger documentation to perform it in onAttach() as mentioned in When to Inject

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

nayan-dhabarde commented 3 years ago

@googlebot I signed it!