android / architecture-components-samples

Samples for Android Architecture Components.
https://d.android.com/arch
Apache License 2.0
23.4k stars 8.29k forks source link

WorkManagerSample throws NullPointerException and IndexOutOfBoundsException #986

Closed dalcomdev closed 1 year ago

dalcomdev commented 3 years ago
  1. When selecting a image, there's a IndexOutOfBoundsException in FilterViewModel. Change FilterViewModel > workInfo to return WorkInfo List, it works fine. Accordingly, observer needs to be changed so that it can accepts List.
  2. SelectImageActivity > handleImageRequestResult: It should be changed to handle both clipData and data, otherwise NullPointerException will throw.
keyboardsurfer commented 3 years ago

Please resolve existing conflicts so we can continue to merge this PR.

calren commented 3 years ago

The first error was fixed in this merged pr: https://github.com/android/architecture-components-samples/pull/1017