search

android / architecture-samples

A collection of samples to discuss and showcase different architectural tools and patterns for Android apps.
Apache License 2.0
44.48k stars 11.65k forks source link

Sample MVP with Clean Architecture and Dagger2? #121

Closed funyoung closed 1 year ago

funyoung commented 8 years ago

I was finish about working on an example Clean Dagger2. MVP + Clean Architecuture + Dagger2, which combines mvp-clean to mvp-dagger2, and I wonder if there was an existing example?

JoseAlcerreca commented 8 years ago

Hey funyoung,

Are you asking if we already have mvp-clean-dagger? We don't, although it's a highly requested sample!

Do you want us to review it and put it under "external samples" for now?

Looks like you based it on the dagger sample and then incorporated the interactors and the rest of the Clean stuff. Did you merge it with the existing Clean branch or did you implement your own version?

funyoung commented 8 years ago

Hello JoseAlcerreca,

I am so exciting to hear that mvp-clean-dagger is a highly requested sample.

I think my code is ready for your review and I'd like to know if it was able to be put under "external samples".

You are right, I based it on the dagger sample, and manually move the interactors and the some others code from the Clean stuff, and then I change all the code of dependency injected with Dagger2.

What should I do next for you to review it and put it under "external samples" then?

JoseAlcerreca commented 8 years ago

Hey funyoung, can you create a PR in your repo so we can review and add comments?

funyoung commented 8 years ago

Hi JoseAlcerreca, I created a PR and signed CLA.

mspmax commented 8 years ago

Hi @funyoung, I'm really keen on looking at the design of your code as I have done something similar as well. Is your branch official now in external samples ?

funyoung commented 7 years ago

@mspmax I thought the code is ready, but the PR was reject as old one.

tunjid commented 1 year ago

Closing as obsolete in the context of the current architecture guide.