search

android / architecture-samples

A collection of samples to discuss and showcase different architectural tools and patterns for Android apps.
Apache License 2.0
44.5k stars 11.65k forks source link

Architecture Sample Proposal with Koin #789

Open arnaudgiuliani opened 3 years ago

arnaudgiuliani commented 3 years ago

Hello!

I would like to propose a version of the app, done with Koin. A branch is almost ready here: https://github.com/InsertKoinIO/architecture-samples/tree/dev-koin

Are you interested? What is the process to integrate it?

Thanks.

JoseAlcerreca commented 3 years ago

Hey Arnaud! That looks great!

The project is meant to be used a base for other repos, such as the one you linked. We're not linking to external repos anymore because they tend to get outdated quickly (as our own does!) and we can't review all of them. We're moving towards a single version of the app using all the recommended tools in the architecture guidance.

Btw there's an error in the README: The ServiceLocator class is removed. Object creation and scoping is handled by Hilt.

Also, I'd link to the "compare" view of the dev-hilt vs dev-koin in the README or Koin's documentation, which is useful to show a migration path: https://github.com/android/architecture-samples/compare/dev-hilt...InsertKoinIO:dev-koin

Good job!

arnaudgiuliani commented 3 years ago

Hey Jose,

The project is meant to be used a base for other repos, such as the one you linked. We're not linking to external repos anymore because they tend to get outdated quickly (as our own does!) and we can't review all of them. We're moving towards a single version of the app using all the recommended tools in the architecture guidance.

Yep, if you're interested having a Koin part. Let me know I can help.

Btw there's an error in the README: The ServiceLocator class is removed. Object creation and scoping is handled by Hilt.

Yep, perhaps still some typos.

Also, I'd link to the "compare" view of the dev-hilt vs dev-koin in the README or Koin's documentation, which is useful to show a migration path: dev-hilt...InsertKoinIO:dev-koin

Do you want a more descriptive README file here?

Thanks.