search

android / architecture-samples

A collection of samples to discuss and showcase different architectural tools and patterns for Android apps.
Apache License 2.0
44.3k stars 11.62k forks source link

Pull to refresh doesn't work when there are no tasks #916

Open dturner opened 1 year ago

dturner commented 1 year ago

Steps to repro:

Expected outcome

Actual outcome

Further details:

Pull to refresh is implemented in the LoadingContent composable. This either displays empty content or if it is non empty (specified by the logic tasks.isEmpty() && !loading) a container which supports pull to refresh.

So the problem is that the empty content should be displayed inside a container which supports pull to refresh.

Additionally the code is currently using SwipeRefresh from the accompanist library which is deprecated and needs migrating https://google.github.io/accompanist/swiperefresh/#migration

AnirudhPudari commented 1 year ago

@dturner Please review the issue as addressed here in this PR https://github.com/android/architecture-samples/pull/934. Thank you

AnirudhPudari commented 1 year ago

@dturner @manuelvicnt @tunjid Please take a look and review this PR https://github.com/android/architecture-samples/pull/934. Thank you

dturner commented 1 year ago

Sorry for the delay. Please fix the spotless formatting on the PR.