search

android / architecture-samples

A collection of samples to discuss and showcase different architectural tools and patterns for Android apps.
Apache License 2.0
44.3k stars 11.62k forks source link

Migrate to KSP #930

Open tunjid opened 1 year ago

tunjid commented 1 year ago

Replace usages of KAPT with KSP as appropriate:

AnirudhPudari commented 1 year ago

@tunjid Hey, I can take this issue, can you please assign it to me.

tunjid commented 1 year ago

@AnirudhPudari all yours!

AnirudhPudari commented 1 year ago

@tunjid Hi, I have made the changes as required. Please review. I was only able to migrate room to KSP. Hilt still doesn't have the support yet as mentioned here in list of supported libraries docs https://kotlinlang.org/docs/ksp-overview.html#supported-libraries. The issue tracker has no ETA provided on Hilt support till now since 2021.

Currently with this change we still will have to keep KAPT to support hilt. would you suggest keeping both KAPT and KSP or should we wait till hilt gets the KSP support ?

tunjid commented 1 year ago

@AnirudhPudari I've merged your PR, thanks again. I've also updated the tasks to show one of the items has been completed.

AnirudhPudari commented 1 year ago

@tunjid Thank you 😊