android / architecture-samples

A collection of samples to discuss and showcase different architectural tools and patterns for Android apps.
Apache License 2.0
44.16k stars 11.6k forks source link

[Data layer codelab] #953

Closed FookThisOffical closed 1 year ago

FookThisOffical commented 1 year ago

Despite last time being updated at Apr27, 2023 and as the project's name suggests; this project doesn't follow most parts of Recommended Architecture suggested by Android Developers. Aside from that, some pieces of the codes sections doesn't satisfy the least required by the compiler and the language. case in point: attempting to reference to a function that's also a member and so references to such elements are not allowed! The content is overwhelmed, lost and unsure, and yet not offering any solidarity of contexts which leads to code's structure inability to be understood and instantiated especially by a beginner. Parts that need to be taking the coder to walk through the project, giving him guidance entirely or partially, are written before without any contemplation of how vague it may seem if not at least having a brief explanation about them. Take note "..how it fits into your overall app architecture" is not considering and thoughtful walkthrough method, It should've only taken you half of the sentence to recognize that. Do better or don't! because making confusion's easy as that and making solution twice as hard as that when being confused. Thank you for being reasonable.