[Data layer codelab] Section 7 (Create the task repository) should reuse mapped data

[hecosw]

Here: suspend fun refresh() { val networkTasks = networkDataSource.loadTasks() localDataSource.deleteAll() val localTasks = withContext(dispatcher) { networkTasks.toLocal() } localDataSource.upsertAll(networkTasks.toLocal()) }

The last line should probably read: localDataSource.upsertAll(networkTasks.toLocal())

[iencotech]

I think it should use the localTasks instead of converting the network tasks to local again, otherwise the withContext() has no purpose:

suspend fun refresh() {
    val networkTasks = networkDataSource.loadTasks()
    localDataSource.deleteAll()
    val localTasks = withContext(dispatcher) {
        networkTasks.toLocal()
    }
    localDataSource.upsertAll(localTasks) // Fixed this line
}

[MahdiRahmani80]

I got this problem and I fixed this another way! I've gone to FakeTaskDao.kt and added this line tasksStream.emit(tasks) my code now looks like this:

  override suspend fun upsertAll(tasks: List<LocalTask>) {
    val newTaskIds = tasks.map { it.id }
    _tasks.removeIf { newTaskIds.contains(it.id) }
    _tasks.addAll(tasks)
    tasksStream.emit(tasks) // this line
  }

I think this solution is a little bit better, because the upsertAll function doesn't emit newly updated tasks.