Update deprecated code in CameraXBasic

android / camera-samples

Multiple samples showing the best practices in camera APIs on Android.

Apache License 2.0

5.01k stars 2.34k forks source link

Update deprecated code in CameraXBasic #525

Closed donovanfm closed 1 year ago

donovanfm commented 1 year ago

This pull request addresses issue https://github.com/android/camera-samples/issues/512.

Main changes:

Replace externalMediaDirs with MediaStore
Replace onRequestPermissionsResult with registerForActivityResult
Replace ListenableFuture with asynchronous coroutine
Replace View.systemUiVisibility with WindowInsetsControllerCompat (falling back for api level 29 and before)
Replace FragmentStatePagerAdapter with FragmentStateAdapter

donovanfm commented 1 year ago

Thanks for the review, Jag! I addressed your comments, and I can look into Rooms to clean up the cursor code. I agree that it can be a follow-up change.