search

android / camera-samples

Multiple samples showing the best practices in camera APIs on Android.
Apache License 2.0
4.95k stars 2.32k forks source link

Update Camera2Basics Sample dependencies #549

Closed iambaljeet closed 4 months ago

iambaljeet commented 1 year ago

Update Project dependencies to most recent versions. Update gradle to most recent versions.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

stevebroshar commented 7 months ago

Seems that this PR is sorely needed in the codebase. Merge it please.

Seems like BS that you require an agreement for a PR. The code is open source. What does an agreement protect? When you merge it, you are responsible for the change, not the submitter. A PR is a suggestion for you to take as-is or as hint for your own change.

I logged a bug yesterday that this PR probably fixes. If you had committed it when it was submitted (months ago), then I would not have wasted time debugging build failures, logging a bug and begging you to commit this.