search

android / codelab-android-dagger

Apache License 2.0
183 stars 157 forks source link

Optional SplashActivity #29

Open filograno opened 4 years ago

filograno commented 4 years ago

This PR solves the optional step of the Dagger codelab, solving the issue #4 too.

googlebot commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

hoangcongtuan commented 3 years ago

Thanks for your solution, but i don't understand why we need SplashComponent?