search

android / codelab-android-dynamic-features

Apache License 2.0
123 stars 47 forks source link

Confirmation dialog is displayed multiple times if one module requires user confirmation #2

Closed gfabrego closed 5 years ago

gfabrego commented 5 years ago

Steps to reproduce

  1. Add some resources to a module so it's bigger than 10MB and requires user confirmation in order to be installed
  2. Do a fresh install from the Play Store.
  3. Open the app
  4. Click on "Install all features now"

Result

The confirmation dialog to install new modules is shown four times, one for each module. This is because it's iterating over module names when state is "confirmation required"

Expectation

Dialog should be shown only once

pfmaggi commented 5 years ago

Thanks for reporting this. We have verified the problem and fixed with commit 1b81133c32b93bc2cd0a3fc6ea3982c12258211a

There's now an additional step in the codelab that showcase this case.

Again: Thanks for helping improving the code and the codelab!