android / codelab-android-dynamic-features

Apache License 2.0
123 stars 47 forks source link

"9. Converting the other modules" missing step to comment out dependencies #37

Open jkurtw opened 3 years ago

jkurtw commented 3 years ago

In 9. Converting the other modules the first step says to "remove the dependency from the modules" in app/build.gradle. However, the code shown below this step is about changing "implementation" to "api" instead of commenting out the following: implementation project(':kotlin') implementation project(':java') implementation project(':native')

Without commenting those lines, you get a build error about circular transitive dependencies.