search

android / codelab-android-hilt

Apache License 2.0
355 stars 188 forks source link

Kotlin, gradle and dependencies versions update #50

Closed osuleymanova closed 2 years ago

osuleymanova commented 2 years ago

Kotlin, hilt versions updated AGP and Gradle versions updated libraries number versions updated implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" line removed buildToolsVersion line removed

osuleymanova commented 2 years ago

Thanks for the note. The line is removed and the build is successful.

On Tue, Oct 4, 2022 at 12:09 PM Kat Kuan @.***> wrote:

@.**** commented on this pull request.

In app/src/main/java/com/example/android/hilt/ui/MainActivity.kt https://github.com/googlecodelabs/android-hilt/pull/50#discussion_r987240933 :

@@ -43,6 +43,7 @@ class MainActivity : AppCompatActivity() { } }

  • @Deprecated("Deprecated in Java")

can this be removed too?

— Reply to this email directly, view it on GitHub https://github.com/googlecodelabs/android-hilt/pull/50#pullrequestreview-1130483158, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUTO2I7OGRWSY3IAQJAPLTLWBR6GNANCNFSM6AAAAAAQ4CNX4I . You are receiving this because you authored the thread.Message ID: @.***>