search

android / codelab-android-paging

Jetpack Paging codelab
Apache License 2.0
495 stars 268 forks source link

Typo in 18. Getting the page based on the LoadType #174

Closed AlexPopov487 closed 3 years ago

AlexPopov487 commented 3 years ago

There is a typo in the second paragraph of "LoadType.APPEND" :

"If remoteKeys is null, that means the refresh result is not in the database yet. We can return Success with endOfPaginationReached = false because Paging will call this method again if RemoteKeys becomes non-null. If remoteKeys is not null but its prevKey is null, that means we've reached the end of pagination for append."

There must have been nextKey instead of a prevKey. The same typo is duplicated in the comments in the code snippet right below the first typo

tunjid commented 3 years ago

Hi! Thanks for bringing this up, I'm currently in the process of fixing it.

AlexPopov487 commented 3 years ago

Happy to help:)

чт, 17 июн. 2021 г., 13:53 Adetunji Dahunsi @.***>:

Hi! Thanks for bringing this up, I'm currently in the process of fixing it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/googlecodelabs/android-paging/issues/174#issuecomment-863059389, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARY4YB5JZEDNJVH4QNXDGY3TTGZZBANCNFSM4623WH5Q .

tunjid commented 3 years ago

@AlexPopov487 this should be fixed now, thanks again for pointing it out.