Bug: Endless fetching on finite lists - Githubissues

android / codelab-android-paging

Jetpack Paging codelab

Apache License 2.0

491 stars 260 forks source link

Bug: Endless fetching on finite lists #215

Closed ogartaganis closed 2 years ago

ogartaganis commented 2 years ago

Description

Fixed some logical errors;

lastRequestedPage incrementation is skipped if not going through the requestMore so added to the requestAndSaveData instead as it was leading to erroneous counting
Requesting was endless even though the results might have been finite. Fixed by keeping the totalItemCount from the response and adding it to the condition of either to request more or not.

Testing

Search for a term with finite results in the current version of the app (I sought for orestis)
Observe the logs. Even tho the results are 78 (at time of writing), the search goes on and on adding pages. It gets worse as you scroll up and down.

ogartaganis commented 2 years ago

Will reopen with the correct CLA information..