Timber instead of Log??

android / codelab-android-workmanager

Apache License 2.0

549 stars 239 forks source link

Timber instead of Log?? #295

Open tindelik opened 2 years ago

tindelik commented 2 years ago

In Background work with WorkManager - Kotlin, step 6 - Chain your work. code for BlurWorker.kt

... return try { if (TextUtils.isEmpty(resourceUri)) { Timber.e("Invalid input uri") <--- Should Timber not be Log? throw IllegalArgumentException("Invalid input uri") } ...

esafak commented 1 year ago

https://developer.android.com/codelabs/android-workmanager#5

vinz2112 commented 1 year ago

Hi, yes "Timber" indeed !!! I think this is supposed to be a joke (and it's a VERY funny one lol) : The code is supposed to be "Log.e ..." but the developer has put "Timber" instead ... makes me think of lumberjacks shouting "TTttttiiimmmmmbbbeeerrrrrr !!!" as they fell the trees ......... REALLY funny I thought ... well done whoever coded that hahaha ;-)