Spinner never stops running in final version code

[rafipanoyan]

Inside the "Learn advanced coroutines with Kotlin Flow and LiveData" codelab, section 14, the spinner is supposed to stop by calling

.onCompletion {  _spinner.value = false }

In fact it never stops since onCompletion is supposed to run after the flow is completed, and not supposed to run after each new value inside the channel.

You can test that by running the finished_code module after removing the lines 133 and 147 of PlantListViewModel. The comments above say that they must be removed after the Flow refact but they are still there.

[rafipanoyan]

IMO the spinner state should be updated to false inside the mapLatest lambda, just as the _spinner.value = true

[rafipanoyan]

It's a duplicate of #60 , closing it now