search

android / compose-samples

Official Jetpack Compose samples.
https://developer.android.com/jetpack/compose
Apache License 2.0
20.22k stars 4.81k forks source link

Jetcaster UI updates #1489

Closed simona-anomis closed 1 day ago

simona-anomis commented 4 weeks ago

Add to Jetcaster: shared elements, swipetodismiss, lazy list animations and removal of episode from queue

https://github.com/user-attachments/assets/95d6c54a-1f62-4bc9-8903-920296dd212b

yongsuk44 commented 3 weeks ago

With PR #1486 merged into the main branch, I have worked on updating the logic in this PR to use only Grid. Would it be alright to contribute these changes to the current branch?

If you are working on this separately, feel free to skip this comment.

https://github.com/user-attachments/assets/a2994e92-8fcd-47fb-965b-21c01c97272d

simona-anomis commented 2 weeks ago

With PR #1486 merged into the main branch, I have worked on updating the logic in this PR to use only Grid. Would it be alright to contribute these changes to the current branch?

  • I have modified it so that the AnimationScope is not applied when the device is unfolded and the detail screen is open.
  • I fixed an issue where SharedElementTransition was not applied in the library list.

If you are working on this separately, feel free to skip this comment.

fold.mp4

Hiya @yongsuk44 - thanks for your contributions! Just to clarify - have you already made these changes locally, but just haven't committed to this PR? If so, please let me know, as I was planning to do this today :) just so we don't duplicate the work. If you've already done the work, please feel free to commit to this branch. Thanks again!

yongsuk44 commented 2 weeks ago

@simona-anomis I've created a separate PR #1492 to merge into the 'jetcaster-ui-update' branch. Could you please take a look? 🙂