search

android / compose-samples

Official Jetpack Compose samples.
https://developer.android.com/jetpack/compose
Apache License 2.0
20.22k stars 4.81k forks source link

[Jetcaster] Fixed to enable SharedElementTransition to run in the Grid list #1492

Closed yongsuk44 closed 1 day ago

yongsuk44 commented 2 weeks ago

The PR for #1489.

simona-anomis commented 2 weeks ago

LGTM, but I'll let @riggaroo give the final approval before merging :) thanks for doing this @yongsuk44

riggaroo commented 2 weeks ago

Thanks @yongsuk44 for working on this and @simona-anomis for tagging! This change may need to wait for the next stable release of Compose, since official Lazy Grid support for shared elements only just got merged (https://android-review.git.corp.google.com/c/platform/frameworks/support/+/3287098) . I'm just checking in with Doris to confirm what issues we'd see.

riggaroo commented 2 weeks ago

Thanks @yongsuk44 for working on this and @simona-anomis for tagging! This change may need to wait for the next stable release of Compose, since official Lazy Grid support for shared elements only just got merged (https://android-review.git.corp.google.com/c/platform/frameworks/support/+/3287098) . I'm just checking in with Doris to confirm what issues we'd see.

We will need to unfortunately wait for Compose 1.8 for this upgrade, as right now even though shared elements look like they are working okay in Lazy Grids, they could cause unknown crashes and issues with scrolling etc.

simona-anomis commented 1 day ago

Spoke to @riggaroo , we will merge this now into my branch https://github.com/android/compose-samples/pull/1489

Then, when 1.8 is stable, we'll merge that into main :) thanks for the contribution @yongsuk44