search

android / identity-samples

Multiple samples showing the best practices in identity on Android.
Apache License 2.0
366 stars 221 forks source link

Compose sample for CredentialManager #76

Open yschimke opened 5 months ago

yschimke commented 5 months ago

Adapting the sample for compose instead of fragments seems complex. I've done this before, but also made mistakes, so a compose sample would help the adoption.

I guess Compose + MAD, such as ViewModels, which complicate where you hoist auth logic and state.

yschimke commented 5 months ago

Found https://github.com/Dashlane/android-passkey-example

Which I have no affiliation with, but is quite helpful.

niharika2810 commented 5 months ago

Hi We are working on this, you will get this by next month. The code is in review phase

There's a rough branch which has atleast the Compose and MAD (we are working on a refined MAD practices and clean version), please check glitch_me_sample branch

yschimke commented 5 months ago

Thanks, great news.

Do you want any feedback on it?

niharika2810 commented 5 months ago

Hey, are you asking about current branch or the one which we are refining. Once we upload that code on main branch (somewhere in May), please feel free to share the feedback :)

ber4444 commented 2 months ago

How is this coming along?

niharika2810 commented 2 months ago

Hey this is in review, will be out once done. Thanks!

aarchish commented 2 months ago

Hi We are working on this, you will get this by next month. The code is in review phase

There's a rough branch which has atleast the Compose and MAD (we are working on a refined MAD practices and clean version), please check glitch_me_sample branch

Hello Niharka, I see that the branch you mention was last updated 1 year ago you yesterday's comment says "this is in review" - did you mean glitch_me_sample branch with Compose ?

yschimke commented 2 months ago

I believe this means an internal Google review process, that all samples need to go through before they are published to GitHub.

aarchish commented 2 months ago

I believe this means an internal Google review process, that all samples need to go through before they are published to GitHub.

Hello yschimke, I was specifically asking this in regard to previous context of using Compose and MAD with Credential Manager API

aarchish commented 1 month ago

Hello @niharika2810,

are we still waiting for the PR to go through?

niharika2810 commented 4 weeks ago

Hey we are still refining a few bits. It should be there this week. If you want to see on a high level, you can check the compose branch as of now. Branch name is https://github.com/android/identity-samples/tree/credman-compose/Shrine

We will keep you posted. Internal reviews take some time. THank you all the patience.

yschimke commented 6 days ago

@niharika2810 I tried the Compose sample, it was very simple to use, worked first time. Nice work.

niharika2810 commented 6 days ago

Great 😃 Thank you Yuri

On Mon, Sep 23, 2024, 3:26 PM Yuri Schimke @.***> wrote:

@niharika2810 https://github.com/niharika2810 I tried the Compose sample, it was very simple to use, worked first time. Nice work.

— Reply to this email directly, view it on GitHub https://github.com/android/identity-samples/issues/76#issuecomment-2367741978, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJXAH436NHTVO47MGUY6FETZX7QVHAVCNFSM6AAAAABGWMEML6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRXG42DCOJXHA . You are receiving this because you were mentioned.Message ID: @.***>