search

android / ndk-samples

Android NDK samples with Android Studio
http://developer.android.com/ndk
Apache License 2.0
9.97k stars 4.15k forks source link

Sanitizer: Make it more portable #971

Closed robotchaoX closed 2 months ago

robotchaoX commented 6 months ago

[Why] Use cmake variable rather than fixed name sanitizers. Make it more portable and has no impact.

[How] Use cmake variable rather than fixed name sanitizers.

DanAlbert commented 2 months ago

I don't understand what this makes more portable. Did you see the build.gradle? This can't be fully driven from CMakeLists.txt, as some of the critical decisions are already made by the time CMakeLists.txt is "run".

robotchaoX commented 2 months ago

Thanks for your review. Sorry for the immature idea. Drop this PR.