Usability improvements for hello-vulkan sample

android / ndk-samples

Android NDK samples with Android Studio

http://developer.android.com/ndk

Apache License 2.0

10.06k stars 4.18k forks source link

Usability improvements for hello-vulkan sample #982

Closed kocdemir closed 7 months ago

kocdemir commented 7 months ago

Move member functions to a cpp file
Remove redundant functions and calls
Report validation layer messages to logcat
Auto-disable validation layers when not found
Feature support checks to avoid validation failures Extra logging to help with debugging when using the app

kocdemir commented 7 months ago

@DanAlbert @GOOG-sergiu

DanAlbert commented 7 months ago

Move member functions to a cpp file

Combining this with the other changes has made this more or less impossible to review, because github shows every line as changed. Could you please split this into multiple PRs?

kocdemir commented 7 months ago

sure, will upload 2 PRs, thanks.