search

android / ndk-samples

Android NDK samples with Android Studio
http://developer.android.com/ndk
Apache License 2.0
9.97k stars 4.15k forks source link

Support for armv8 arch only devices #994

Closed nfynt closed 2 months ago

nfynt commented 3 months ago

Recent pixel devices do not report armv7 arch support and only arm64-v8a. This causes benchmark test to exit early with message stating "Not an ARMv7 and not an X86 SSSE3 CPU !\n".

This update includes check for ANDROID_CPU_FAMILY_ARM64 along with subsequent cmake and gradle updates for running the test app.

google-cla[bot] commented 3 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

DanAlbert commented 2 months ago

I think you probably need to update https://github.com/android/ndk-samples/blob/ece52f26503987bbfd2ded8c73ffde05c457d035/hello-neon/app/src/main/cpp/helloneon-intrinsics.c#L18?

DanAlbert commented 2 months ago

Actually it was the CMakeLists.txt that needed updating. Pushed the fix to your branch.