android / ndk

The Android Native Development Kit
1.92k stars 253 forks source link

[Bug]: Lambda segfaults in Clang #2035

Open FireBurn opened 4 days ago

FireBurn commented 4 days ago

Description

This bug has caused segfaults compiling Android projects using lambdas and affects the whole 18.1 series

I've got a version of the patch that applies cleanly to 18.1.8 https://github.com/FireBurn/PortageStuff/blob/master/patches/sys-devel/clang/0001-Tweak-tryCaptureVariable-for-unevaluated-lambdas-932.patch

Upstream bug

https://github.com/llvm/llvm-project/issues/67260

Commit to cherry-pick

https://github.com/vedantparanjape-amd/llvm-project/commit/251b29d7a40a247c913e999ade839748ae350a6f

Affected versions

r27

Canary version

No response

Host OS

Linux

Host OS version

Gentoo

Affected ABIs

arm64-v8a, x86_64

DanAlbert commented 4 days ago

Thanks. We'll check the test case in the PR to see if this is a regression from r26. If not, it'll be fixed in r28 for sure, but it'd probably wait for r27b (we'll see though, we're already respinning for a regression fix, so might be able to pick this up too).

pirama-arumuga-nainar commented 4 days ago

https://github.com/llvm/llvm-project/issues/67260 says this regressed due to an LLVM change in september so it is likely a regression in r27. Will try to cherry-pick the fix.

DanAlbert commented 4 days ago

Ah, thanks. I'd skimmed it but missed that bit.

appujee commented 3 days ago

Picked in: https://android-review.googlesource.com/c/toolchain/llvm_android/+/3148958

FireBurn commented 3 days ago

Thanks

pirama-arumuga-nainar commented 3 days ago

Picked in: https://android-review.googlesource.com/c/toolchain/llvm_android/+/3148958

That's a different cherry-pick. The fix for this bug hasn't been cherry-picked yet.