search

android / ndk

The Android Native Development Kit
1.96k stars 255 forks source link

clang should use `-Wl,--exclude-libs,libgcc.a` by default #823

Closed DanAlbert closed 3 years ago

DanAlbert commented 5 years ago

Would help avoid issues like those discussed in https://github.com/android-ndk/ndk/issues/379

tomty89 commented 5 years ago

That doesn't seem to do a thing (while -Wl,--exclude-libs,libgcc.a and/or -Wl,--exclude-libs,libunwind.a does; as libgcc.a is now a linker script?)

mhsmith commented 4 years ago

As mentioned here, the name to use is now libgcc_real.a.

tomty89 commented 4 years ago

That's what I meant, IIRC. I think I missed the _real in my last comment. Shouldn't this be changed to, "clang should use -Wl,--exclude-libs,libgcc_real.a and -Wl,--exclude-libs,libunwind.a" (because -Wl,--exclude-libs doesn't seem to work for linker script)?

DanAlbert commented 4 years ago

We're hoping to be off libgcc by r23, so this will probably not be fixed.

lattice0 commented 3 years ago

Why libgcc_real.a should be excluded?

By the way, I'm getting:

  [1369/1369] Linking CXX shared library /home/dev/orwell/orwell_flutter_app/build/app/intermediates/cmake/debug/obj/armeabi-v7a/liborwell_android.so
  FAILED: /home/dev/orwell/orwell_flutter_app/build/app/intermediates/cmake/debug/obj/armeabi-v7a/liborwell_android.so 
  : && /opt/android-sdk-linux/ndk/21.1.6352462/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++ --target=armv7-none-linux-androideabi24 --gcc-toolchain=/opt/android-sdk-linux/ndk/21.1.6352462/toolchains/llvm/prebuilt/linux-x86_64 --sysroot=/opt/android-sdk-linux/ndk/21.1.6352462/toolchains/llvm/prebuilt/linux-x86_64/sysroot -fPIC -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -march=armv7-a -mthumb -Wformat -Werror=format-security  -std=c++17 -O0 -fno-limit-debug-info  -Wl,--exclude-libs,libgcc.a -Wl,--exclude-libs,libgcc_real.a -Wl,--exclude-libs,libatomic.a -static-libstdc++ -Wl,--build-id -Wl,--fatal-warnings -Wl,--exclude-libs,libunwind.a -Wl,--no-undefined -Qunused-arguments -shared -Wl,-soname,liborwell_android.so -o /home/dev/orwell/orwell_flutter_app/build/app/intermediates/cmake/debug/obj/armeabi-v7a/liborwell_android.so CMakeFiles/orwell_android.dir/orwell_jni.cpp.o CMakeFiles/orwell_android.dir/DecodedFfmpegFrameJNI.cpp.o CMakeFiles/orwell_android.dir/JavaOrwellFlutterRenderer.cpp.o CMakeFiles/orwell_android.dir/MediaCodecDecoder.cpp.o CMakeFiles/orwell_android.dir/JavaSimpleFileWriter.cpp.o CMakeFiles/orwell_android.dir/JavaHashMapJNI.cpp.o CMakeFiles/orwell_android.dir/JavaFlutterEventMessenger.cpp.o  _liborwell/liborwell_static.a -landroid -llog -lmediandk /home/dev/orwell/orwell_flutter_app/android/app/src/main/cpp/../../../../../../deps/ffmpeg/build/android/armeabi-v7a/lib/libavcodec.so /home/dev/orwell/orwell_flutter_app/android/app/src/main/cpp/../../../../../../deps/ffmpeg/build/android/armeabi-v7a/lib/libavutil.so /home/dev/orwell/orwell_flutter_app/android/app/src/main/cpp/../../../../../../deps/ffmpeg/build/android/armeabi-v7a/lib/libswscale.so /home/dev/orwell/orwell_flutter_app/android/app/src/main/cpp/../../../../../../deps/ffmpeg/build/android/armeabi-v7a/lib/libswresample.so /home/dev/orwell/orwell_flutter_app/build/app/intermediates/cmake/debug/obj/armeabi-v7a/libmyRtspClient.so /home/dev/orwell/orwell_flutter_app/build/app/intermediates/cmake/debug/obj/armeabi-v7a/libjrtp.so _liborwell/_myRtspClient/libmyRtspClient-static.a _liborwell/_myRtspClient/_JTRPLIB/src/libjrtp.a _liborwell/_ZLMediaKit/libzlmediakit.a _liborwell/_ZLMediaKit/libzltoolkit.a _liborwell/_ZLMediaKit/libmpeg.a _liborwell/_ZLMediaKit/libmov.a _liborwell/_ZLMediaKit/libflv.a _liborwell/common/openvpn_zl_socket/libopenvpn_zl_socket.a _liborwell/_libopenvpn3/src/libopenvpn/libopenvpn_lib.a _liborwell/_libopenvpn3/openvpn3/libssl.a _liborwell/_libopenvpn3/openvpn3/libcrypto.a _liborwell/_libopenvpn3/openvpn3/liblzo.a _liborwell/_libopenvpn3/openvpn3/liblz4.a _liborwell/_libopenvpn3/libtins/lib/libtins.a _liborwell/_libopenvpn3/smoltcp_cpp_interface/libsmoltcp_cpp_static.a /home/dev/orwell/deps/libopenvpn3/smoltcp_cpp_interface/target/armv7-linux-androideabi/release/libsmoltcp_cpp_interface_rust.a -ldl _liborwell/common/liborwellebml/liborwell_ebml.a _liborwell/_libebml/libebml.a _liborwell/common/liborwellprofile/liborwell_profile.a _liborwell/common/liborwellprofile2/liborwell_profile2.a _liborwell/common/liborwellprofile2/_protobuf/libprotobufd.a /opt/android-sdk-linux/ndk/21.1.6352462/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/lib/arm-linux-androideabi/libz.a -latomic -lm && :
  /opt/android-sdk-linux/ndk/21.1.6352462/toolchains/llvm/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: /opt/android-sdk-linux/ndk/21.1.6352462/toolchains/llvm/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/armv7-a/thumb/libgcc_real.a(_arm_addsubsf3.o): multiple definition of '__aeabi_ul2f'
  /opt/android-sdk-linux/ndk/21.1.6352462/toolchains/llvm/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: /home/dev/orwell/deps/libopenvpn3/smoltcp_cpp_interface/target/armv7-linux-androideabi/release/libsmoltcp_cpp_interface_rust.a(compiler_builtins-5ae026d08032e786.compiler_builtins.2kv22hwk-cgu.127.rcgu.o): previous definition here
  clang++: error: linker command failed with exit code 1 (use -v to see invocation)                                
  ninja: build stopped: subcommand failed.

as you see, my linking command already has -Wl,--exclude-libs,libgcc_real.a but I still get this error

DanAlbert commented 3 years ago

Obsolete with r23 because we've switched to LLVM's libunwind, which doesn't need this because it's built with hidden visibility.