[Bug]: CI allows merging PRs with failing checks - Githubissues

android / nowinandroid

A fully functional Android app built entirely with Kotlin and Jetpack Compose

Apache License 2.0

15.95k stars 2.82k forks source link

[Bug]: CI allows merging PRs with failing checks #1045

Open SimonMarquis opened 7 months ago

SimonMarquis commented 7 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Is there a StackOverflow question about this issue?

[X] I have searched StackOverflow

What happened?

Initial push, all checks are run:

Screenshot 2023-11-18 093425

Because commit contains UI changes, an automated commit `🤖 Updates screenshots` is added, resetting all checks but `cla/google`

Resulting in `✅ All checks have passed`

For reference, this is what happened in #942 breaking the main branch after merge. And #1044 for a simpler example.

Relevant logcat output

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct

JoseAlcerreca commented 2 months ago

I've been looking for a way to work around this, but to avoid recursion GHA doesn't let workflows start other worflows. SO thread.

SimonMarquis commented 2 months ago

You can either do that with PAT or a GitHub app (Google probably already has such bot available on other Google repos).