Closed dturner closed 4 weeks ago
Overall Project | 40.34% -0.49% |
:green_apple: |
---|---|---|
Files changed | 57.67% | :x: |
Module | Coverage | |
---|---|---|
foryou | 56.16% -3.2% |
:x: |
bookmarks | 51.21% -1.59% |
:x: |
interests | 49.95% -3.74% |
:x: |
topic | 47.33% -2.09% |
:x: |
app | 32% -0.09% |
:green_apple: |
Overall Project | 40.34% -0.49% |
:green_apple: |
---|---|---|
Files changed | 55.61% | :x: |
Module | Coverage | |
---|---|---|
foryou | 56.16% -3.2% |
:x: |
bookmarks | 51.21% -1.59% |
:x: |
interests | 49.95% -3.69% |
:x: |
topic | 47.33% -2.09% |
:x: |
app | 32% -0.09% |
:green_apple: |
Overall Project | 40.37% -0.49% |
:green_apple: |
---|---|---|
Files changed | 55.94% | :x: |
Module | Coverage | |
---|---|---|
foryou | 56.16% -3.2% |
:x: |
bookmarks | 51.21% -1.59% |
:x: |
interests | 49.95% -3.69% |
:x: |
topic | 47.33% -2.09% |
:x: |
app | 32.04% -0.09% |
:green_apple: |
Overall Project | 40.36% -0.49% |
:green_apple: |
---|---|---|
Files changed | 58.1% | :x: |
Module | Coverage | |
---|---|---|
foryou | 56.16% -3.2% |
:x: |
bookmarks | 51.21% -1.59% |
:x: |
interests | 49.95% -3.69% |
:x: |
topic | 47.33% -2.09% |
:x: |
app | 32.1% -0.06% |
:green_apple: |
Overall Project | 40.58% -0.5% |
:green_apple: |
---|---|---|
Files changed | 52.96% | :x: |
Module | Coverage | |
---|---|---|
foryou | 56.21% -3.25% |
:x: |
bookmarks | 52.3% -1.59% |
:x: |
interests | 48.73% -3.8% |
:x: |
topic | 47.23% -2.09% |
:x: |
app | 33.08% -0.08% |
:green_apple: |
Overall Project | 41.48% -0.2% |
:green_apple: |
---|---|---|
Files changed | 70.51% | :green_apple: |
Module | Coverage | |
---|---|---|
foryou | 60.17% -1.09% |
:x: |
bookmarks | 55.06% -1.25% |
:x: |
interests | 50.52% -1.63% |
:x: |
topic | 49.92% -0.7% |
:green_apple: |
app | 30.43% -0.05% |
:green_apple: |
Overall Project | 44.67% -0.21% |
:green_apple: |
---|---|---|
Files changed | 70.12% | :green_apple: |
Module | Coverage | |
---|---|---|
foryou | 60.31% -0.79% |
:x: |
bookmarks | 54.03% -1.25% |
:x: |
interests | 50.35% -2.15% |
:x: |
topic | 49.92% -0.7% |
:green_apple: |
app | 48.47% -0.04% |
:green_apple: |
Overall Project | 42.34% -0.21% |
:green_apple: |
---|---|---|
Files changed | 69.28% | :green_apple: |
Module | Coverage | |
---|---|---|
bookmarks | 52.45% -1.15% |
:x: |
foryou | 52.31% -0.75% |
:x: |
app | 48.16% -0.06% |
:green_apple: |
interests | 45.28% -1.93% |
:x: |
topic | 44.14% -0.73% |
:green_apple: |
Could you check this PR release mode onto the device or emulator? May the @Serializable
Route be obfuscated, and makes runtime error. In this, you need to update a proguard rules.
Overall Project | 42.31% -0.21% |
:green_apple: |
---|---|---|
Files changed | 69.28% | :green_apple: |
Module | Coverage | |
---|---|---|
bookmarks | 52.45% -1.15% |
:x: |
foryou | 52.31% -0.75% |
:x: |
app | 48.16% -0.06% |
:green_apple: |
interests | 45.28% -1.93% |
:x: |
topic | 44.14% -0.73% |
:green_apple: |
Overview Navigation 2.8.0 introduces type-safe APIs for the Navigation DSL. Instead of using strings for routes and argument names, you can define types which are verified at compile-time. This blog post explains more.
What have I done and why Migrated the navigation code from strings to types. For example, here's the old navigation code for the topic feature:
And here's the new type-safe code:
Note that there's no need to URL encode the arguments because there's no danger of them being interpreted as placeholders (e.g. "{topicId}") in the route string (because there is no route string).
I have also updated the app manifest to allow deeplinks to be tested from the terminal. Example:
adb shell am start -a android.intent.action.VIEW -d "https://www.nowinandroid.apps.samples.google.com/foryou/2" com.google.samples.apps.nowinandroid.demo.debug