Interests and Topic feature modules should be merged

android / nowinandroid

A fully functional Android app built entirely with Kotlin and Jetpack Compose

Apache License 2.0

16.62k stars 3.01k forks source link

Interests and Topic feature modules should be merged #1414

Open dturner opened 5 months ago

dturner commented 5 months ago

Previously we had an authors module so the module structure was:

interests
- authors
- topics

Now that we no longer have authors, the nested structure adds complexity for no benefit, making it especially difficult to understand the navigation graph. Suggest merging :topics into :interests (whilst keeping the Topic model).

This would enable InterestsListDetailScreen which is currently in the :app module to be moved into the feature module.

Jaehwa-Noh commented 5 months ago

The merged two modules, seemed too big and coarse grained to me. What about just moving InterestListDetailScreen and Interests2PaneViewModel into :interests?