search

android / nowinandroid

A fully functional Android app built entirely with Kotlin and Jetpack Compose
Apache License 2.0
16.62k stars 3.01k forks source link

Fix state loss with workaround #1419

Closed alexvanyo closed 4 months ago

alexvanyo commented 5 months ago

This is a continuation of #1383 .

After merging #1380 , the state loss issue appeared again that is due to https://issuetracker.google.com/338478720

This additional workaround doesn't change behavior the direct behavior of consuming insets (and shouldn't have any difference overall) but avoids the state loss issue again.

github-actions[bot] commented 5 months ago

Combined test coverage report

Overall Project 40.54% :green_apple:
Files changed 100% :green_apple:


Module Coverage
app 32.73% :green_apple:
Files |Module|File|Coverage|| |:-|:-|:-|:-:| |app|[NiaApp.kt](https://github.com/android/nowinandroid/blob/149f0c93f32d26766e1d91f9e9e717a840805299/app%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fgoogle%2Fsamples%2Fapps%2Fnowinandroid%2Fui%2FNiaApp.kt)|83.52%|:green_apple:|
github-actions[bot] commented 5 months ago

Combined test coverage report

Overall Project 40.51% :green_apple:
Files changed 100% :green_apple:


Module Coverage
app 32.73% :green_apple:
Files |Module|File|Coverage|| |:-|:-|:-|:-:| |app|[NiaApp.kt](https://github.com/android/nowinandroid/blob/a324fcc8d3f4ffe21a7e56c1c37a61d71c4ee3af/app%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fgoogle%2Fsamples%2Fapps%2Fnowinandroid%2Fui%2FNiaApp.kt)|83.52%|:green_apple:|
github-actions[bot] commented 4 months ago

Combined test coverage report

Overall Project 39.77% :x:
Files changed 100% :green_apple:


Module Coverage
app 30.44% :green_apple:
Files |Module|File|Coverage|| |:-|:-|:-|:-:| |app|[NiaApp.kt](https://github.com/android/nowinandroid/blob/488b97a0716574a33e9e30b30984f644cefdafe2/app%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fgoogle%2Fsamples%2Fapps%2Fnowinandroid%2Fui%2FNiaApp.kt)|86.54%|:green_apple:|