search

android / nowinandroid

A fully functional Android app built entirely with Kotlin and Jetpack Compose
Apache License 2.0
16.62k stars 3.01k forks source link

[Bug]: Added New screenshot have failed in CI local test #1421

Closed Jaehwa-Noh closed 4 months ago

Jaehwa-Noh commented 4 months ago

Is there an existing issue for this?

Is there a StackOverflow question about this issue?

What happened?

Added New screenshot have failed in CI local test #1296

I had added new screenshot for snackbar test on my Mac. See below. https://github.com/android/nowinandroid/pull/1296/commits/afe53f90966cd35a4f7233d7a8a4aa7ea84ff45f

But, the result was failed because of these differences. Here is the output from CI.

snackbar_expanded_expanded_compare

snackbar_medium_medium_compare

What I'm missing? or What should I do?

Relevant logcat output

No response

Code of Conduct

SimonMarquis commented 4 months ago

@Jaehwa-Noh you can let the CI generate them for you. Simply open a PR in your fork, and the CI will automatically commit these files during the build.

Jaehwa-Noh commented 4 months ago

@SimonMarquis Aha, the screenshot tests followed Single-Source-Of-Truth. Good. I totally understand. Thank you SimonMarquis!