android / nowinandroid

A fully functional Android app built entirely with Kotlin and Jetpack Compose
Apache License 2.0
16.62k stars 3.01k forks source link

Loading Wheel flexible number of lines #1431

Closed JackEblan closed 4 months ago

JackEblan commented 4 months ago

Thanks for submitting a pull request. Please include the following information.

What I have done and why

The number of lines in Loading Wheel is set to 12 and there is no way to change this because the rotate degrees for each line drawn is hard-coded to rotate(degrees = index * 30f)

How I'm testing it

Choose at least one:

Do tests pass?

Is this your first pull request?

Jaehwa-Noh commented 4 months ago

What situation we need to customize the rotationTimeInMillis and numberOfLines?

JackEblan commented 4 months ago

By making this loading composable customizable like:

SimonMarquis commented 4 months ago

This is a great contribution, but I don't think this will ever be merged. Providing a customizable design system is definitely not the primary goal of this project.