[FR]: Upgrade to AGP 8.4 - Githubissues

android / nowinandroid

A fully functional Android app built entirely with Kotlin and Jetpack Compose

Apache License 2.0

15.93k stars 2.81k forks source link

[FR]: Upgrade to AGP 8.4 #1433

Closed jvandort closed 1 month ago

jvandort commented 1 month ago

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the problem

Gradle uses NIA as a sample project for its performance tests. Since NIA is not compatible with AGP 8.4, we cannot update Gradle's tests to perform validations against AGP 8.4. These include both our smoke tests and performance benchmarks, as they both test against the same AGP versions.

Describe the solution

Update NIA to build with AGP 8.4

Additional context

This blocks the following Gradle PR: https://github.com/gradle/gradle/pull/29102

Code of Conduct

[X] I agree to follow this project's Code of Conduct

jvandort commented 1 month ago

@alexvanyo You upgraded to 8.3 last time. How difficult do you think this upgrade will be?

SimonMarquis commented 1 month ago

@dependabot should have taken care of it like in this PR:

https://github.com/android/nowinandroid/pull/1114

Unfortunately, I think the project accumulated too many open PRs: https://github.com/android/nowinandroid/blob/7f2ce57c67c68aa921de9231525a4a47ef431fe8/.github/dependabot.yml#L21

Shameless nudge:

https://github.com/android/nowinandroid/issues/1083

jvandort commented 1 month ago

Thank you for the quick turn-around time!