search

android / nowinandroid

A fully functional Android app built entirely with Kotlin and Jetpack Compose
Apache License 2.0
15.93k stars 2.81k forks source link

Remove the printModulePaths task and read modules direct from settings #1460

Closed dturner closed 1 month ago

dturner commented 1 month ago

What I have done and why I've updated the generateModuleGraphs.sh script to remove the dependency on the printModulePaths gradle task. This task was unnecessarily run during the gradle configuration phase and has now been removed. Instead, the bash script just reads the module paths direct from settings.gradle.kts.

Also referenced here: https://github.com/android/nowinandroid/pull/1293

github-actions[bot] commented 1 month ago

Combined test coverage report

Overall Project 40.57% :green_apple:

There is no coverage information present for the Files changed

Jaehwa-Noh commented 1 month ago

There are different way to define include projects. include(":app", ":core:common", ":core:database", ":feature:foryou", ":core:datastore")

This way wouldn't be your regex work properly. But current project doesn't use that way, so that It looks good choice alternative way to get modules path.