search

android / nowinandroid

A fully functional Android app built entirely with Kotlin and Jetpack Compose
Apache License 2.0
16.61k stars 3.01k forks source link

Replace bash commands with proper svgo cli #1506

Closed SimonMarquis closed 3 months ago

SimonMarquis commented 3 months ago

Although this adds another requirement to execute this script, it will prevent OS-specific issues on sed and grep as described in #1503, and make sure anyone can generate the same SVG output files.

--pretty is kept for convenience but can be removed if needed.

Closes #1503

dturner commented 3 months ago

Not overly keen on the dependency on node.js introduced by svgo, however, this is better than the current situation of platform-specific issues with sed and grep. Thanks.