search

android / nowinandroid

A fully functional Android app built entirely with Kotlin and Jetpack Compose
Apache License 2.0
15.92k stars 2.81k forks source link

Apply version catalog in the convention plugins #1517

Open Jaehwa-Noh opened 1 week ago

Jaehwa-Noh commented 1 week ago

Apply version catalog in the convention plugins.

dturner commented 2 days ago

Please explain why this is a good idea. At first glance, the lines like this: 

libs.findPlugin("compose").get().get().pluginId

look less readable than the original

apply(plugin = "org.jetbrains.kotlin.plugin.compose")
Jaehwa-Noh commented 2 days ago

@dturner I think this is the good for SSOT, and when we would change plugins, we can change name or group in just one place libs.versions.toml. I agreed with you it is hard to read then origin, but I think that we can remove .get().get() using extension function.

Kindly leave your comment here. I'll change or close this PR. Thank you.