search

android / nowinandroid

A fully functional Android app built entirely with Kotlin and Jetpack Compose
Apache License 2.0
16.93k stars 3.09k forks source link

[Bug]: Not able to return to "For You" screen from Topic screen #1597

Open devwindsw opened 2 months ago

devwindsw commented 2 months ago

Is there an existing issue for this?

Is there a StackOverflow question about this issue?

What happened?

[Repro Steps]

  1. Click a topic in "For You" screen and verify that the topic screen is launched
  2. Click "Back" button in the top bar
  3. Click "For You" tab in the bottom bar

[Expected Result] We can navigate to "For You".

[Actual Result] We're not able to navigate to "For You" until restart the app

[Frequency] 100%

Screen_recording_20240906_023148.webm

Relevant logcat output

No response

Code of Conduct

anhtuannd commented 2 months ago

Maybe it's duplication of https://github.com/android/nowinandroid/issues/1463 and https://github.com/android/nowinandroid/issues/1465

devwindsw commented 2 months ago

Maybe it's duplication of #1463 and #1465

It seems that the PR should be update since base code changed.

However, it seems that the PR may have a regression. Tab "For You" repeatedly, then we can observe the flickering of the screen.

anhtuannd commented 2 months ago

I rebased my commit to latest. You can check again, apparently I don't see this happen.

devwindsw commented 1 month ago

I rebased my commit to latest. You can check again, apparently I don't see this happen.

In "with_fix", we can find "LoadingWheel" is displayed and disappears shortly but not in "without_fix".

without_fix.webm with_fix.webm