android / performance-samples

Samples to show APIs and best practices in Performance on Android
https://d.android.com/topic/performance/overview
Apache License 2.0
1.27k stars 214 forks source link

Samples doesn't work for dynamic feature modules #251

Closed Hessesian closed 1 year ago

Hessesian commented 1 year ago

Hi, I implemented these samples into official sample for acessing dynamic feature modules https://github.com/Hessesian/android-dynamic-code-loading

And when running the benchmark, it will not load the dynamic feature module data, presumably because of install command from android test plugin that will only install main apk instead of entire bundle, any suggestions or workarounds ? Thanks

keyboardsurfer commented 1 year ago

Currently Baseline Profiles and running benchmarks are only supported for the base module when using dynamic feature modules.

Hessesian commented 1 year ago

Thanks for clarification, are there any plans on supporting this ? We have a project where core features are setup as install-time dynamic features and if we should change it to library, depending on planned support for this

keyboardsurfer commented 1 year ago

We're working through several issues around feature modules with benchmarking. Have you tried fused install time modules?

keyboardsurfer commented 1 year ago

Also, this is likely the issue you have described above.