android / socialite

Apache License 2.0
346 stars 60 forks source link

Refactor - Camera UI Adaptation for Foldable Devices and Camera Initialization #52

Open yongsuk44 opened 5 months ago

yongsuk44 commented 5 months ago

To-do

Example screen

fold_capture.webm

romanofranz commented 5 months ago

Thanks for doing this! There are 2 issues when running it on the Pixel Fold (physical device):

yongsuk44 commented 5 months ago

@romanofranz Thanks, I'll check back. 😀

yongsuk44 commented 5 months ago

@romanofranz

I removed the code that locked the screen orientation when the orientation changes in the camera composable.

Screen_recording.webm

romanofranz commented 5 months ago

Thanks, this works better! There are still few issues:

Overall LGTM on the camera side, adding @donovanfm to check the rest of the refactoring. Good job!