search

android / sunflower

A gardening app illustrating Android development best practices with migrating a View-based app to Jetpack Compose.
https://d.android.com/jetpack
Apache License 2.0
17.65k stars 4.68k forks source link

data binging and setOnclickListener #116

Open Malachiasz opened 6 years ago

Malachiasz commented 6 years ago

Why to use onClickListener on the binding if listener can be defined on xml level?

XinyueZ commented 6 years ago

@Malachiasz Most of the click listeners are defined in xml (recycler-view adapter for example). There's a PR #91 which contains impl. of +/- button in detail page with data-binding as well.

If any listener is forgotten you can make a PR to fix or write down here , letz know it.

Malachiasz commented 6 years ago

ListItemPLantBinding and PlantAdapter set OnClickListener.

XinyueZ commented 6 years ago

@Malachiasz try a PR to optimize?