search

android / sunflower

A gardening app illustrating Android development best practices with migrating a View-based app to Jetpack Compose.
https://d.android.com/jetpack
Apache License 2.0
17.66k stars 4.71k forks source link

InstantApp support #55

Open PaulProject opened 6 years ago

PaulProject commented 6 years ago

Does android-sunflower support InstantApp projects (feature modules)?

tiembo commented 6 years ago

There are plans to support Instant Apps but it's lower priority at the moment. Let's use this issue as a placeholder.

andhie commented 6 years ago

since Instant App is not categorised under Jetpack umbrella, why would it be supported? to implement most of the stuffs in Jetpack itself is already an app complex enough.

XinyueZ commented 6 years ago

@tiembo The whole project struct would be changed little, however, it is almost standard for android apps with instantapp feature-module.

tiembo commented 6 years ago

@andhie similar to Material Design, Instant Apps is indeed not a Jetpack component but is an important part of an Android development story. Let's keep this issue open so others can also add their input.

sagar-viradiya commented 6 years ago

Core focus of this project should be jetpack. Personally I don't think it's worth to have instant app support. As @tiembo mentioned it should be low priority.

XinyueZ commented 6 years ago

@sagar-viradiya Perhaps you are right, but using instant-app simply changes the dependency structure of the entire project and does not involve a change in business logic.

neiljaywarner commented 6 years ago

since this project is linked directly from getting started-jetpack and jetpack is being pushed so much, I feel it would be great if it gets put in soon.

Isn't instant apps even an option under file-new project?

Due to the nature of it it could - at least for some projects - be a non-trivial change later, so it definitely seems like it should be considered foundational.

Yes, i understand the differences between 'well structured' and 'ready for instant apps' may not be large, but it would be awesome if sunflower as a starting point included it.

thank you for your consideration