search

android / sunflower

A gardening app illustrating Android development best practices with migrating a View-based app to Jetpack Compose.
https://d.android.com/jetpack
Apache License 2.0
17.57k stars 4.67k forks source link

[Task] Update dependencies and clean version catalog #936

Closed anselmoalexandre closed 6 months ago

anselmoalexandre commented 6 months ago

Hi team,

In this PR, I have cleanup and versions catalog file, introducing [bundles] block packaging together group of dependencies of the same flavour offering me dependency readability.

Please review Thanks

google-cla[bot] commented 6 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

bentrengrove commented 6 months ago

Thanks for the contribution, this looks like multiple unrelated changes grouped together which means we wouldn't be able to merge it.

We would love adding the Portuguese strings to the app, could you please create a new PR just with those changes? The rest I don't think we could accept unfortunately as I don't see the benefit.

anselmoalexandre commented 6 months ago

Thanks for the contribution, this looks like multiple unrelated changes grouped together which means we wouldn't be able to merge it.

  • There are what look to be test changes in the HomeScreen file
  • I don't think we need the gradle file reformatting
  • The Portuguese strings file

We would love adding the Portuguese strings to the app, could you please create a new PR just with those changes? The rest I don't think we could accept unfortunately as I don't see the benefit.

Thanks @bentrengrove for the feedback. About the multiple unrelated changes, my bad on that, I actually branched from my old PR which is #655 for the Portuguese translation I did a while back. Kindly take a look on it.

Now, reformatting the version catalog file to introducing bundles, make the gradle dependencies more readable and combining related group libraries together.

Thanks