search

android / tv-samples

Multiple samples showing best practices in app development on Android TV.
Apache License 2.0
1.02k stars 329 forks source link

feat: use engage-sdk for continue watching #150

Open vighnesh153 opened 5 months ago

vighnesh153 commented 5 months ago

This Pull request integrates Engage SDK with TV samples app. In the current implementation, we are making use of androidx.tvprovider to update the Watch Next program row on a TV device. Since androidx.tvprovider is no longer maintained and we are now moving towards cross-device continue watching, we are migrating to making use of Engage SDK to publish to the watch next program row on a TV device.

jpgpuyo commented 5 months ago

Hello @vighnesh153, Thanks a lot for your effort. I have tried reference app in Chromecast HD with Google TV and Play Next row is not working any more. I suspect that the issue is that in Google TV we have 'Continue watching' row instead of 'Play Next'.

Once this new SDK is integrated, can you clarify which is the compatibility with older TVs with 'Play next' row?

Thanks!

vighnesh153 commented 5 months ago

2 reasons why the integration isn't working:

  1. Engage SDK 1.4.0 version is not yet published engage-sdk-maven-repo
  2. Engage Service has an allowlisting mechanism at the backend to allow only certain apps to publish to tv provider. Currently, this Reference app is not yet allowlisted for publishing to TV provider.
chikoski commented 4 months ago

I will review this PR, but I am not familiar with the API.

@miguelmontemayor Would you please review this PR if it uses API properly or not?