Fix build error - Githubissues

android / tv-samples

Multiple samples showing best practices in app development on Android TV.

Apache License 2.0

1.06k stars 338 forks source link

Fix build error #151

Closed chikoski closed 10 months ago

chikoski commented 10 months ago

This pull request mainly intended to fix the gradle sync failure due to missing androidx-compose-ui-tooling in libs.versions.toml.

In addition to that, the PR includes the following two things:

Dependency update
Removal of custom clean task from the build.gradle.kts, so that we can run the built-in clean task.
A fix of type error in DashBoard.kt

vighnesh153 commented 10 months ago

FYI: Even this PR was addressing a similar thing: https://github.com/android/tv-samples/pull/145/files

pankajXdev commented 10 months ago

FYI: Even this PR was addressing a similar thing: https://github.com/android/tv-samples/pull/145/files

It was earlier :/

JolandaVerhoef commented 10 months ago

You're right that it was earlier. However, it did not solve the problem in the correct way, as it didn't add the dependency to the libs.versions.toml file which is the best practice. As this PR includes the right fix and also includes some extra fixes, we'd prefer to directly merge this one.