search

android / views-widgets-samples

Multiple samples showing the best practices in views-widgets on Android.
Apache License 2.0
5.04k stars 3.01k forks source link

ViewPager2 nested scroll in parallel doesn't work when SwipeRefreshLayout is in view hierarchy #100

Closed RustamG closed 4 years ago

RustamG commented 4 years ago

Hi,

The official solution to resolve nested scrolling in the same direction as ViewPager2 orientation doesn't work when one of its ancestors is SwipeRefreshLayout.

Here is a diff of the sample to reproduce it: https://github.com/RustamG/views-widgets-samples/commit/3dc2bdf4302a58c1b1de8376224557505a093daa

jfresen commented 4 years ago

Hi,

Can you try to see if it works with the latest version of SwipeRefreshLayout, 1.1.0-alpha04?

On Wed, 25 Dec 2019, 11:51 Rustam Gilyaev, notifications@github.com wrote:

Hi,

The official solution https://github.com/android/views-widgets-samples/blob/master/ViewPager2/app/src/main/java/androidx/viewpager2/integration/testapp/NestedScrollableHost.kt#L38 to resolve nested scrolling in the same direction as ViewPager2 orientation doesn't work when one of its ancestors is SwipeRefreshLayout.

Here is a diff of the sample to reproduce it: master...RustamG:master https://github.com/android/views-widgets-samples/compare/master...RustamG:master

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/android/views-widgets-samples/issues/100?email_source=notifications&email_token=AADMXOM2RPAURKENADW7JMDQ2M3J7A5CNFSM4J7EH362YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICTEWIA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADMXONXOAKZJ4CVGTSZPM3Q2M3J7ANCNFSM4J7EH36Q .

RustamG commented 4 years ago

1.1.0-alpha04 fails to resolve for me (not yet released?), but with 1.1.0-alpha03 it works in the sample app. Thanks @jfresen!

jfresen commented 4 years ago

Ah, my bad. I was looking at the next version code, not the current version code. Thanks for sorting that out!

On Wed, 25 Dec 2019, 13:50 Rustam Gilyaev, notifications@github.com wrote:

1.1.0-alpha04 fails to resolve for me (not yet released?), but with 1.1.0-alpha03 it works in the sample app. Thanks @jfresen https://github.com/jfresen!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/android/views-widgets-samples/issues/100?email_source=notifications&email_token=AADMXOPLCTWY2PKKQ6DHLB3Q2NJJVA5CNFSM4J7EH362YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHUKUZI#issuecomment-568896101, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADMXOO2KC7DFG24CR57LT3Q2NJJVANCNFSM4J7EH36Q .